Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rmt): Fixed protocol name in RMTReadXJT examples #11136

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

tanakamasayuki
Copy link
Contributor

Description of Change

I couldn't find a protocol called D12.
I found LR12 so I'll fix that.

Tests scenarios

Find the desired protocol.

Related links

image
https://www.frsky-rc.com/wp-content/uploads/2017/07/Manual/XJT.pdf
manual(PDF)

pascallanger/DIY-Multiprotocol-TX-Module#239
Protocol information, but not open information.

I couldn't find a protocol called D12.
I found LR12 so I'll fix that.
Copy link
Contributor

github-actions bot commented Mar 18, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(RMT): changing example commentary to reflect D16 protocol":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello tanakamasayuki, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against bfae8d5

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +2720.00⚠️ +0.08000.000.00
ESP32S30⚠️ +1080.00⚠️ +0.03000.000.00
ESP32S20⚠️ +1120.00⚠️ +0.04000.000.00
ESP32C30⚠️ +1260.00⚠️ +0.04000.000.00
ESP32C60⚠️ +1560.00⚠️ +0.06000.000.00
ESP32H20⚠️ +1260.00⚠️ +0.04000.000.00
ESP320⚠️ +1600.00⚠️ +0.05000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/RMT/RMTReadXJT⚠️ +2720⚠️ +1080⚠️ +1120⚠️ +1260⚠️ +1560⚠️ +1260⚠️ +1600

@me-no-dev
Copy link
Member

This is D16 and not LR12. Not sure why it said D12. Please note that this example is probably 9 years old or more and is possible that some protocols have been redefined

@SuGlider
Copy link
Collaborator

Changed it to D16.

@SuGlider SuGlider added this to the 3.2.0 milestone Mar 19, 2025
@SuGlider SuGlider added Area: Peripherals API Relates to peripheral's APIs. Type: Example Issue is related to specific example. labels Mar 19, 2025
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Mar 20, 2025
@me-no-dev me-no-dev merged commit 7fda434 into espressif:master Mar 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants