Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zigbee): Fix and bump zigbee version and stay on 1.6.0 #10563

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix(zigbee): Fix and bump zigbee version and stay on 1.6.0 #10563

merged 2 commits into from
Nov 4, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Nov 4, 2024 •
edited by lucasssvaz
Loading

Description of Change

Fixes changes on Zigbee 1.6.0 version and keep that version fixed in idf_component.yml

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Requires #10544

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Warnings
⚠️ 
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 02ef2e4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Test Results

 56 files   56 suites   4m 18s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 02ef2e4.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 4, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev November 4, 2024 16:12
@me-no-dev me-no-dev changed the base branch from master to idf-release/v5.1 November 4, 2024 21:25
@me-no-dev me-no-dev merged commit b06a637 into espressif:idf-release/v5.1 Nov 4, 2024
37 of 47 checks passed
me-no-dev added a commit that referenced this pull request Nov 4, 2024
@P-R-O-C-H-Y @me-no-dev
fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)
740e408 
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Nov 6, 2024
@P-R-O-C-H-Y @me-no-dev
fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)
7ae2553 
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Nov 6, 2024
@P-R-O-C-H-Y @me-no-dev
fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)
d8947e1 
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Nov 6, 2024
@me-no-dev @P-R-O-C-H-Y
IDF release/v5.1 (#10577)
527fc83 
* fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* IDF release/v5.1 f12cfcbc

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* IDF release/v5.1 5b6aa191

* fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* fix(zigbee): Fix removed cluster_role attribute (#10576)

* IDF release/v5.1 5b6aa191

* fix(build): Update package_esp32_index.template.json

---------

Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Nov 13, 2024
@me-no-dev @P-R-O-C-H-Y
IDF release/v5.1 (#10600)
ae3d4e3 
* fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* IDF release/v5.1 f12cfcbc

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* IDF release/v5.1 5b6aa191

* fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* fix(zigbee): Fix removed cluster_role attribute (#10576)

* IDF release/v5.1 5b6aa191

* fix(build): Update package_esp32_index.template.json

* IDF release/v5.1 9439479f

---------

Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
me-no-dev added a commit that referenced this pull request Nov 13, 2024
@me-no-dev @P-R-O-C-H-Y
IDF release/v5.3 (#10599)
3822a68 
* fix(zigbee): Bump zigbee version and use 1.6.0 (#10563)

Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

* fix(zigbee): Add require public for zigbee libs

* fix(zigbee): Guard the Zigbee library

* fix(zigbee): Fix removed cluster_role attribute (#10576)

* fix(hosted): Update hosted configuration

* fix(hosted): Fix Hosted deinit and protect reinit for now

* IDF release/v5.3 a0f798cf

* IDF release/v5.3 a0f798cf

---------

Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-R-O-C-H-Y @me-no-dev