Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rainmaker): Add new partition tables that fits the binary size #10046

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix(rainmaker): Add new partition tables that fits the binary size #10046

merged 3 commits into from
Jul 29, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Jul 18, 2024 •
edited
Loading

Description of Change

This PR adds 2 partitions tables for RainMaker and fixes+renamed the old one:

  • RainMaker -> RainMaker 4MB (with OTA so maximum upload size got fixed)
  • RainMaker 4MB no OTA
  • RainMaker 8MB

Partitions have been updated for all existing boards according to the flash size options.

Tests scenarios

Tested locally on all supported targets.

Related links

Closes #10036

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d059a3a

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev July 18, 2024 14:05
@VojtechBartoska VojtechBartoska added the Area: Rainmaker Issue is related to ESP Rainmaker. label Jul 19, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.4 milestone Jul 19, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged hil_test Run Hardware Tests lib_test Run External Libraries Test labels Jul 23, 2024
@Xylopyrographer Xylopyrographer mentioned this pull request Jul 24, 2024
Merged
@me-no-dev me-no-dev merged commit 0670e20 into espressif:master Jul 29, 2024
20 of 26 checks passed
me-no-dev pushed a commit that referenced this pull request Jul 29, 2024
@Xylopyrographer @pre-commit-ci-lite
feat(board): add Waveshare ESP32-S3-Matrix (#10072)
9e01ebd 
* feat(board) add Waveshare ESP32-S3-Matrix

Adds support for the Waveshare ESP32-S3-Matrix board. Includes changes to the Rainmaker partitions as per PR #10046 .

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Aug 16, 2024
Merged
@merdogmus
Copy link

tools/partitions/rainmaker_8MB.csv is broken. According to the documentation:

Offset must be multiple of 4 kB (0x1000) and for app partitions it must be aligned by 64 kB (0x10000). If left blank, the offset will be automatically calculated based on the end of the previous partition, including any necessary alignment, however, the offset for the first partition must be always set as 0x9000 and for the first application partition 0x10000.

So the ota_1 app ota_1 0x3FD000 0x3ED000 is not valid because offset cannot be 0x3FD000. Please fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees
No one assigned
Labels
Area: Rainmaker Issue is related to ESP Rainmaker. hil_test Run Hardware Tests lib_test Run External Libraries Test Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

ESP Rainmaker does not work with esp32c3
5 participants
@P-R-O-C-H-Y @merdogmus @me-no-dev @lucasssvaz @VojtechBartoska