Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledcAttachPin shoud support output_invert param (IDFGH-8781) #7501

Closed
dkwach opened this issue Nov 21, 2022 · 1 comment · Fixed by #9257
Closed

ledcAttachPin shoud support output_invert param (IDFGH-8781) #7501

dkwach opened this issue Nov 21, 2022 · 1 comment · Fixed by #9257
Assignees
@P-R-O-C-H-Y
Labels
Area: Peripherals API Relates to peripheral's APIs. Type: Feature request Feature request for Arduino ESP32

Comments

@dkwach
Copy link

dkwach commented Nov 21, 2022

Is your feature request related to a problem?

We can imagine that device controlled by ledc driver is connected by NPN or PNP transistor.
It would be perfect to have output inversion, which already is supported by ledc_channel_config called from ledcAttachPin

Describe the solution you'd like.

Extend ledcAttachPin interface to support output_invert

  void ledcAttachPin(uint8_t pin, uint8_t chan, uint8_t output_invert)

Describe alternatives you've considered.

No response

Additional context.

No response
@dkwach dkwach added the Type: Feature request Feature request for Arduino ESP32 label Nov 21, 2022
@github-actions github-actions bot changed the title ledcAttachPin shoud support output_invert param ledcAttachPin shoud support output_invert param (IDFGH-8781) Nov 21, 2022
@igrr
Copy link
Member

igrr commented Nov 21, 2022

IDF already has output_invert member in ledc_channel_config_t (docs).

It looks like you are referring to ledcAttachPin function defined in the arduino-esp32 project here, so I'll move this feature request over to arduino-esp32.

@igrr igrr transferred this issue from espressif/esp-idf Nov 21, 2022
@VojtechBartoska VojtechBartoska added the Area: Peripherals API Relates to peripheral's APIs. label Nov 22, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs. Type: Feature request Feature request for Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(ledc): Add output invert option for LEDC pin + minor fixes P-R-O-C-H-Y/arduino-esp32
4 participants
@igrr @VojtechBartoska @P-R-O-C-H-Y @dkwach