-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Please replace BLE_iBeacon with a more fleshed-out example. #7360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Make a pull request with the example code that you would like to see. The BLE library was originally a community submission, and it continues to be supported largely by the community rather than Espressif. |
@31337Ghost I don't want to steal credit for your work, but I also don't want to give you things to do :) Would you prefer to submit a PR for this, or should I do it? |
@PilnyTomas Can you please check this example and propose some possible solutions? Thank you. |
@Human Open Source software is not only about transparency and free access, it is also about community contribution. If you have a clear idea about the example and you are able to do that we will happily review your Pull Request and add it to this repository. |
@PilnyTomas Ok. I gave the original author time and opportunity to respond, so I will prepare a PR with his work. |
Related area
iBeacon example
Hardware specification
ESP32
Is your feature request related to a problem?
Forum and github searches reveal that many people have problems getting ESP32 boards running https://github.com/espressif/arduino-esp32/blob/master/libraries/BLE/examples/BLE_iBeacon/BLE_iBeacon.ino to be detected by strict iBeacon scanners. Even when a scanner does detect an ESP32 iBeacon, many fields are missing. I came across a discussion here that links to reworked example code here. This worked out of the box for me, whereas BLE_iBeacon.ino only worked partially on some scanners and not at all on others. (EDITED: updated pastebin link to a the full solution)
Describe the solution you'd like
Either replace the legacy BLE_iBeacon.ino with 31337Ghost's reference code, or incorporate its changes into the legacy BLE_iBeacon.ino.
Describe alternatives you've considered
I searched github and forums, and it seems as if most people end up having to modify BLE_iBeacon.ino to achieve basic functions. I don't think there's really an alternative, other than everyone performing the same forum searches and performing the same workarounds.
Additional context
I recommend that devs try the legacy BLE_iBeacon code, then switch to the suggested new reference code, and compare the functionality in various scanners.
I have checked existing list of Feature requests and the Contribution Guide
The text was updated successfully, but these errors were encountered: