-
Notifications
You must be signed in to change notification settings - Fork 7.6k
C3 + S3 Flash - CI test #6884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Adding @Ouss4, so we can discuss if needed here. |
Maybe add a small r/w benchmark to keep an eye for any major issues that affect flash performance? |
@lbernstone Good idea, we can add some test for r/w performance. Adding that to the list. |
Just 2c, there is a benchmarking test for flash performance in several different mode in esp-idf CI. The problem is that it is extremely unreliable:
Given that Arduino-esp32 pretty much directly calls the underlying IDF flash related functions, i think the likelihood of a performance regression is low, while the effort to maintain such a performance test would be relatively high. |
The one thing I see worth testing as speed is to make sure that there is actually a difference between the flash modes. With the latest findings (and until we fix this in the lib-builder) it seems to me that there is a chance that flash modes actually do not correspond to what is being set and enabled by the bootloader. @igrr do you thing that such test makes sense and will work, regradles of the flash chip differences? |
Add flash testing to the GitHub CI. Following needs to be taken care of:
1st round:
2nd round:
The text was updated successfully, but these errors were encountered: