Skip to content

old LORA_RST pin definition in variants/ttgo-lora32-v21new/ #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VeniceInventors opened this issue Dec 3, 2021 · 5 comments
Closed

old LORA_RST pin definition in variants/ttgo-lora32-v21new/ #5966

VeniceInventors opened this issue Dec 3, 2021 · 5 comments

Comments

@VeniceInventors
Copy link

VeniceInventors commented Dec 3, 2021 •
edited
Loading

In the pins_arduino.h pin definition file, at line 30 the reset pin is set to 12 but according to Lilygo's site and this pinout diagram, the reset pin should be set to 23.

< #define LORA_RST    12  // GPIO14 - SX1276 RST
> #define LORA_RST    23  // GPIO23 - SX1276 RST

Pin 23 is also consistent with the Liligo TBeam v1.1
@atanisoft
Copy link
Collaborator

@tobozo can you include this update in your PR?

tobozo added a commit to tobozo/arduino-esp32 that referenced this issue Dec 3, 2021
@tobozo
Fix for LORA_RST (see espressif#5966)
b383c65
@tobozo
Copy link
Contributor

tobozo commented Dec 3, 2021

I hope this time the CI won't need 24h to finish its job 🤣

image

@tobozo
Copy link
Contributor

tobozo commented Dec 10, 2021

see PR #5961

me-no-dev pushed a commit that referenced this issue Dec 14, 2021
@tobozo
Merged all TTGO-LoRa32 Board profiles (see #5933) (#5961)
8c5d18d 
* Merged all TTGO-LoRa32 Board profiles (see #5933)

* Fix for LORA_RST (see #5966)
@atanisoft
Copy link
Collaborator

@me-no-dev this one can be closed since PR #5961 has been merged.

@me-no-dev
Copy link
Member

Thanks @atanisoft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobozo @atanisoft @me-no-dev @VeniceInventors