Skip to content

Align with ESP8266 and fix signature deviation between Arduino.h and WMath.cpp #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dok-net opened this issue May 31, 2021 · 0 comments · Fixed by #5230
Closed

Align with ESP8266 and fix signature deviation between Arduino.h and WMath.cpp #5229

dok-net opened this issue May 31, 2021 · 0 comments · Fixed by #5230
Labels

Comments

@dok-net
Copy link
Contributor

dok-net commented May 31, 2021

As per esp8266/Arduino#8089, newer compilers flag the different types in Arduino.h and WMath.cpp for makeWord as an error. Proactively fix this for ESP32.
A patch is provided in PR #5230

Edit: ESP32 master branch actually fails on this MCVE, too:

void setup()
{
    auto w = makeWord(1024);
    auto w2 = makeWord(192, 193);
}

void loop()
{
}
ld.exe: makeword.cpp.o:(.literal._Z5setupv+0x18): undefined reference to makeWord(unsigned short)

Error linking for board WEMOS D1 MINI ESP32
ld.exe: makeword.cpp.o: in function setup()
makeword.ino:3: undefined reference to makeWord(unsigned short)
Debug build failed for project 'makeword'
 
collect2.exe*: error: ld returned 1 exit status
me-no-dev pushed a commit that referenced this issue Jun 9, 2021
…, common denominator type therefore is uint8_t, which is in use already in Arduino.h, too. (#5230)

Fixes #5229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants