Skip to content

softAPConfig() in WiFiAP.cpp #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yukini3 opened this issue Feb 10, 2017 · 3 comments
Closed

softAPConfig() in WiFiAP.cpp #191

yukini3 opened this issue Feb 10, 2017 · 3 comments

Comments

@yukini3
Copy link

yukini3 commented Feb 10, 2017

There are code error in this API. In softAPConfig, tcpip_adapter_set_ip_info() is called and expecting non-zero return value is successful but zero (ESP_OK) is successful value.
Calling tcpip_adapter_dhcps_start() also the same.

@me-no-dev
Copy link
Member

aaah I though I fixed those a few days ago. Will do

@me-no-dev
Copy link
Member

on another note :)
code is correct ;)
if tcpip_adapter_set_ip_info returns non-zero, then it failed and dhcps will be started. Error is that it should return false, regardless of what tcpip_adapter_dhcps_start returns.

@me-no-dev
Copy link
Member

nevermind... too much code in my head... this is AP not STA

blue-2357 pushed a commit to blue-2357/arduino-esp32 that referenced this issue Jul 17, 2024
brentru pushed a commit to adafruit/arduino-esp32 that referenced this issue Oct 22, 2024
darkxst pushed a commit to darkxst/arduino-esp32 that referenced this issue Dec 5, 2024
dash0820 added a commit to dash0820/arduino-esp32-stripped that referenced this issue Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants