Utilized UPDATE_ERROR_ERASE, added _setError function and refactored code #4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_setError function wraps a few lines to eliminate repetitiveness when debugging for errors.
_setError function wraps a few lines to eliminate repetitiveness when debugging for errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two boolean results in _writeBuffer() function, thus utilized UPDATE_ERROR_ERASE. This helps to notice whether ESP.flashEraseSector or ESP.flashWrite was unsuccessful when an error occurs. Previously, it would only show UPDATE_ERROR_WRITE.
With the request of @devyte , added _setError function to wrap some lines up and tidied the code.