show symbol size in symbol list #268
Merged
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BR-
commented
Oct 2, 2025
BR-
commented
|
This is great! 2 nice-to-haves:
|
encounter
reviewed
Oct 4, 2025
objdiff-gui/src/views/appearance.rs
Outdated
| pub diff_colors: Vec<Color32>, | ||
| pub diff_bg_color: Option<Color32>, | ||
| pub theme: egui::Theme, | ||
| pub show_symbol_sizes: ShowSymbolSizeState, |
There was a problem hiding this comment.
Let’s put this in SymbolViewState instead!
objdiff-gui/src/views/appearance.rs
Outdated
|
|
||
| #[derive(serde::Deserialize, serde::Serialize, PartialEq, Debug)] | ||
| pub enum ShowSymbolSizeState { | ||
| Off, |
There was a problem hiding this comment.
Can derive(Default) and put #[default] on Off
|
Love this, sort by size (ascending/descending) maybe? xd Just kidding, this is cool enough on its own. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.