Use strict float handling in JSON functions #5265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2017 16:55
STRICT_JSON controls the renderer & parser behavior on whether or not to accept non-standard float values (NaN, Infinity).
Contributor
Author
|
@sbchisholm, @andyneff - does this provide the expected behavior? |
| @@ -0,0 +1,33 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Worth a docstring here to highlight why we have this module.
Contributor
|
This is ace. Nice work @rpkilby! |
lovelydinosaur
approved these changes
Jul 12, 2017
Contributor
|
Looks great. Deferring to 3.7.0. |
6 tasks
carltongibson
pushed a commit
that referenced
this pull request
Oct 6, 2017
* Set version number for 3.7.0 release * Rename release notes section Moved issue links to top for easier access. (Can move back later) * Add release note for #5273 * Add release note for #5440 * Add release note for #5265 Strict JSON handling * Add release note for #5250 * Add release notes for #5170 * Add release notes for #5443 * Add release notes for #5448 * Add release notes for #5452 * Add release not for #5342 * Add release notes for 5454 * Add release notes for #5058 & #5457 Remove Django 1.8 & 1.9 from README and setup.py * Release notes for merged 3.6.5 milestone tickets Tickets migrated to 3.7.0 milestone. * Add release notes for #5469 * Add release notes from AM 2ndOct * Add final changes to the release notes. * Add date and milestone link Move issue links back to bottom. * Update translations from transifex * Begin releae anouncement * Add release note for #5482 * 3.7 release announcement & related docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4918, fix #5235. The important bits that I gathered from the discussion were:
JSONField) may not be compatible with the extended float values (Infinity,NaN). Incompatible values should raise an exception.This PR does the following:
rest_framework.utils.jsonmodule that defaults to strict JSON encoding/decoding.rest_framework.utils.json, so they obey the stricter behavior.settings.STRICT_JSON, which controls the strictness ofJSONParser&JSONRenderer. This defaults toTrue, but users can revert to the old extended behavior by setting this toFalse