Add tools/emcoverage.py to obtain coverage information #9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Aug 7, 2019
tlively
reviewed
Aug 7, 2019
tlively
reviewed
Aug 7, 2019
|
I'm ok with python3 here.. it can be seen as part of our move away from python2: #7198 |
sbc100
added a commit
that referenced
this pull request
Aug 7, 2019
While reviewing #9166 I noticed that support a PYTHON key in the config file but this doesn't effect any of the entry point (on UNIX the entry points are defined by the #! line, on windows they are are defined as `python` in the bat files. So really this was only effecting python sub-processes not the compiler itself. This feature doesn't seem like its useful, and also has no tests, so removing it for now. However for the benefit of #9166 add support for setting this via the `EM_PYTHON` environment variable.
sbc100
added a commit
that referenced
this pull request
Aug 8, 2019
While reviewing #9166 I noticed that support a PYTHON key in the config file but this doesn't effect any of the entry point (on UNIX the entry points are defined by the #! line, on windows they are are defined as `python` in the bat files. So really this was only effecting python sub-processes not the compiler itself. This feature doesn't seem like its useful, and also has no tests, so removing it for now. However for the benefit of #9166 add support for setting this via the `EM_PYTHON` environment variable.
tlively
reviewed
Aug 14, 2019
tlively
approved these changes
Aug 15, 2019
sbc100
added a commit
that referenced
this pull request
May 20, 2020
It doesn't make sense for emscripten to be running under one python version and then launch sub-processes under a different one. I had thought that emsdk used this it sets EMSDK_PYTHON which can be used to launch emscripten, but once launched we want to continue to use the version of python we started out with. I first added support for this in #9175 supposedly for the benefit of #9166, but that change didn't end up using it anyway.
sbc100
added a commit
that referenced
this pull request
May 21, 2020
It doesn't make sense for emscripten to be running under one python version and then launch sub-processes under a different one. I had thought that emsdk used this but it sets EMSDK_PYTHON which can be used to launch emscripten, but once launched we want to continue to use the version of python we started out with. I first added support for this in #9175 supposedly for the benefit of #9166, but that change didn't end up using it anyway.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
While reviewing emscripten-core#9166 I noticed that support a PYTHON key in the config file but this doesn't effect any of the entry point (on UNIX the entry points are defined by the #! line, on windows they are are defined as `python` in the bat files. So really this was only effecting python sub-processes not the compiler itself. This feature doesn't seem like its useful, and also has no tests, so removing it for now. However for the benefit of emscripten-core#9166 add support for setting this via the `EM_PYTHON` environment variable.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool will allow us to find exactly what code is not run when using wasm backend, for example, to aid us in removing fastcomp code.