support glDrawBuffers #2530
Merged
support glDrawBuffers #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #if GL_ASSERTIONS | ||
| assert(GL.drawBuffersExt, 'Must have WEBGL_draw_buffers extension to use drawBuffers'); | ||
| #endif | ||
| var bufArray = []; |
There was a problem hiding this comment.
I feel very depressed reading this, but seems like there is no other way to avoid dynamic memory allocation and array push here :/ If there was some way around generating garbage here, that'd be awesome..
There was a problem hiding this comment.
We could reuse the same array, by assigning to indexes 0,1,2 etc. as needed (instead of push), then setting .length if it is different than the current length. Should be very fast that way.
|
This looks good. We should have some form of testing for this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.