Deprecate -sMAYBE_WASM2JS settings #23970
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of this settings will now see: ``` emcc: warning: MAYBE_WASM2JS is deprecated (no known users). Please open a bug if you have a continuing need for this setting [-Wdeprecated] ``` See emscripten-core#23969
|
Ah, I may have confused this with Looks like wasm2js always enables MAYBE_WASM2JS. This may have been useful as a user-facing feature in the past for debugging purposes, but maybe now we can remove it from there (but keep it internally, or refactor). |
Yes, I was think we could keep |
kripken
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of this settings will now see:
See #23969