Sdl audio queueing #1806
Merged
Sdl audio queueing #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er queueing logic more resilient for jitter, and factor out a common parameter 'SDL.audio.numSimultaneouslyQueuedBuffers' that can be used to tune for a good quality<->latency balance.
8 tasks
| @@ -1469,7 +1469,7 @@ var LibrarySDL = { | |||
| } else if (SDL.audio.channels != 1 && SDL.audio.channels != 2) { // Unsure what SDL audio spec supports. Web Audio spec supports up to 32 channels. | |||
| console.log('Warning: Using untested number of audio channels ' + SDL.audio.channels); | |||
| } | |||
| if (SDL.audio.samples < 1024 || SDL.audio.samples > 524288 /* arbitrary cap */) { | |||
| if (SDL.audio.samples < 512 || SDL.audio.samples > 524288 /* arbitrary cap */) { | |||
There was a problem hiding this comment.
why not remove the lower limit at all?
There was a problem hiding this comment.
Very small buffer sizes are nearly insane and will kill cpu processing power. I think it's good to have a limit. I'll lower this to 128, so this can catch any silly bogus values that someone could accidentally pass.
|
Ok, updated the pull request. |
| ++SDL.audio.numAudioTimersPending; | ||
| Browser.safeSetTimeout(SDL.audio.caller, 1.0); | ||
| } | ||
| } |
|
lgtm with indentation fix |
…to allow user code to configure how many SDL audio buffers to keep simultaneously queued up for the audio backend. More buffers means less change of starving (and cracking audio), but increases latency. Fewer buffers lower the latency at the risk of playback glitches. Make minimum audio buffer size 128, which should be way below anything reasonable already. Clean up commented out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves SDL audio streaming support, based on experiences from the MESS codebase. Thanks to Vito`` and DopefishJustin for the feedback!