Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent method naming in tools/webassembly.py. NFC #17253

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 17, 2022

No description provided.

@sbc100 sbc100 requested a review from dschuff June 17, 2022 19:07
@sbc100 sbc100 force-pushed the python_method_naming branch from 925edb0 to df6987f Compare June 17, 2022 19:07
@sbc100 sbc100 enabled auto-merge (squash) June 17, 2022 19:22
@sbc100 sbc100 requested a review from kripken June 17, 2022 19:43
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
or should I say, looks_good_to_me

@sbc100 sbc100 disabled auto-merge June 17, 2022 20:01
@sbc100 sbc100 merged commit ea65615 into main Jun 17, 2022
@sbc100 sbc100 deleted the python_method_naming branch June 17, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants