Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parts of wasm64 export wrapper generation to build time. NFC #17057

Merged
merged 1 commit into from
May 26, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 25, 2022

Specifically the metadata about which exports to wrap is now stored in
the compiler rather than the runtime.

@sbc100 sbc100 changed the title Wasm64 simplify Move parts of wasm64 export wrapper generation to build time. NFC May 25, 2022
@sbc100 sbc100 force-pushed the wasm64_simplify branch from f082df9 to d418fe5 Compare May 25, 2022 17:39
@sbc100 sbc100 requested a review from kripken May 25, 2022 17:39
@sbc100 sbc100 force-pushed the wasm64_simplify branch 2 times, most recently from fb3b0cf to f9c733e Compare May 25, 2022 17:42
@sbc100 sbc100 force-pushed the wasm64_simplify branch from f9c733e to 1bda89a Compare May 25, 2022 22:41
@sbc100 sbc100 requested a review from kripken May 26, 2022 22:39
@sbc100 sbc100 force-pushed the wasm64_simplify branch 2 times, most recently from b1b106b to 06bbc27 Compare May 26, 2022 23:24
Specifically the metadata about which exports to wrap is now stored in
the compiler rather than the runtime.
@sbc100 sbc100 force-pushed the wasm64_simplify branch from 06bbc27 to 2016c14 Compare May 26, 2022 23:29
@sbc100
Copy link
Collaborator Author

sbc100 commented May 26, 2022

Thanks for putting up with all my bad grammar and spelling BTW.

@sbc100 sbc100 merged commit 5b63376 into main May 26, 2022
@sbc100 sbc100 deleted the wasm64_simplify branch May 26, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants