Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_asyncify_lists* name detection #16077

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix test_asyncify_lists* name detection #16077

merged 2 commits into from
Jan 21, 2022

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 21, 2022

Looking for 'name' in the binary leads to false positives with ASan and WasmFS
that have that string in there for other reasons. Instead, use the shiny new
wasm module parsing code 🥳

Remove the TODO here and enable these tests in ASan mode.

@kripken kripken requested a review from sbc100 January 21, 2022 00:47
@kripken
Copy link
Member Author

kripken commented Jan 21, 2022

Oh, I had this partially wrong... ASan always emits a name section. So we just need to skip that one line for asan. All the rest of it passes now.

@kripken kripken enabled auto-merge (squash) January 21, 2022 18:35
@kripken kripken merged commit cf40c4d into main Jan 21, 2022
@kripken kripken deleted the wfname branch January 21, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants