Use compact SPDX license identifer in JS files #10771
Conversation
|
This ended up requiring some more work to get tests passing: Closure compiler will preserve comments in the new format, and |
src/emrun_prejs.js
Outdated
| // found in the LICENSE file. | ||
| /** | ||
| * @license | ||
| * Copyright 2020 Emscripten authors |
There was a problem hiding this comment.
What about preserving those dates?
There was a problem hiding this comment.
How about capital A in authors to match the convention uses here and in chromium. Also the The?
There was a problem hiding this comment.
Happy to change to Authors with capitals.
Adding The seems unnecessary to me? But no feelings either way, adding.
Changing the dates seems unnecessary to me, and I am actually modifying the files now, so the copyright would need to reflect that, I think? But IANAL and maybe you know more?
There was a problem hiding this comment.
Asking some people, the answer is to preserve the year. Changed the PR for that now.
tools/shared.py
Outdated
| @@ -2997,6 +3009,14 @@ class JS(object): | |||
| */ | |||
| ''' | |||
|
|
|||
| closured_emscripten_license = '''\ | |||
| /* | |||
|
|
|||
There was a problem hiding this comment.
Why the extra newline here? And why not use the * at the start of each line ?
There was a problem hiding this comment.
This is the exact format of what closure emits. It changes the /** to /* and removes the @license but keeps an empty line for it. That last part does look a little odd, I agree, but closure doens't give us a flag to change that.
|
Updated to have |
|
I think its generally a good idea to have the original file creation year as the copyright year but I also I'm not a lawyer. |
|
This required some generalization of the closure code workaround, pushed now. |
Also see notes in #10770