Cleanup emcmake/emconfigure #10392
Merged
Cleanup emcmake/emconfigure #10392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
emcmake_cleanup
branch
2 times, most recently
from
1d16c82 to
75f398f
Compare
kripken
reviewed
Feb 12, 2020
| run_process(args, stdout=stdout, stderr=stderr, env=env, **kwargs) | ||
| if 'EMMAKEN_JUST_CONFIGURE' in env: | ||
| del env['EMMAKEN_JUST_CONFIGURE'] |
There was a problem hiding this comment.
why don't we need to clean this up?
There was a problem hiding this comment.
Because env is local thing.. its does not live after this function.
There was a problem hiding this comment.
but env can be passed in as a parameter, in which case we modify it? (do we copy it somewhere that I missed?)
There was a problem hiding this comment.
Oh I think i had an env.copy somewhere in a previous version of this change. I'll re-add that.
kripken
approved these changes
Feb 13, 2020
sbc100
force-pushed
the
emcmake_cleanup
branch
2 times, most recently
from
358a0e7 to
434a7bb
Compare
- Set CMAKE_CROSSCOMPILING_EMULATOR in the same way we set CMAKE_TOOLCHAIN_FILE. - Consisten echoing of make/configure command. - Don't silently succeed if passed no args
sbc100
force-pushed
the
emcmake_cleanup
branch
from
434a7bb to
07df383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_TOOLCHAIN_FILE.