This repository was archived by the owner on Nov 1, 2021. It is now read-only.
Implement emscripten_atomic_fence(). #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a temporary hack, workaround, or something we were always missing? |
|
We were always missing this. The SharedArrayBuffer specification does not have atomic fence operation (it briefly did have it, but people found it too dirty and it was dropped out). Applying any atomic operation has the same effect as a fence, so we perform a no-op operation to implement it. A thought was raised with memory location 0 that a JS AoT compiler would be able to pattern match and compile this to a faster fence operation where applicable. |
|
Ok, thanks. |
juj
added a commit
that referenced
this pull request
May 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.