Added DWARF style debugging information extraction. #138
Conversation
More information is available here: https://gist.github.com/hackcasual/ea77cc31c6dafdda7274
|
Overall impressive work here. And I like that it isn't intrusive. However, LLVM DI is something that changes rapidly. We'll likely have a bunch of extra rebasing work because of this, every time we update from LLVM. Would you be up for doing that work? |
|
Yes, I'm up for it. I'm hoping that once WebAssembly completes its move to use the WebAssembly AsmPrinter, then DWARF can be emitted directly, and then switch to either generate this format directly from DWARF, or switch the Javascript debug interface over to use binary DWARF |
| std::map<unsigned, std::string> VtableOffsets; | ||
| std::ostringstream TypeDebugData; | ||
| std::ostringstream TypeNameMap; | ||
| std::ostringstream FunctionMembers; |
There was a problem hiding this comment.
Where do these streams get initialized? Where does their output go?
Another question, if they are all for CyberDWARF, perhaps they could be in a struct? Or perhaps prefixed with CD? Otherwise the names (like FunctionMembers) don't clearly enough imply that they are for CyberDWARF.
There was a problem hiding this comment.
Moved it to an anonymous struct. Streams are initialized by their default constructor. The streams are built up in a potentially interleaved way so separate streams are needed until output is ready.
TypeDebugData is the types member in the output JSON, TypeNameMap is the type_name_map member, and FunctionMembers is the functions member.
|
Sounds good. |
|
Looks good. I'm ok to land this now before the other pull is done, unless there is further interaction between the two that might change? |
|
Good to go in standalone, all the changes are behind the 2 config flags |
|
Cool. |
Added DWARF style debugging information extraction.
More information is available here: https://gist.github.com/hackcasual/ea77cc31c6dafdda7274
This adds a pass entirely behind a flag to collect the LLVM DI entities for the program, then emits a JSON type tree from those
The debug intrinsics are designed to compile down to no-ops (however I believe they make the generated output non asm.js compatible). They are designed to be replaced by a debugger for reporting on live variables