Skip to content

Conversation

psbanka
Copy link
Contributor

@psbanka psbanka commented Dec 12, 2019

According to this comment, we need to upgrade ember-cli-addon-docs to tailwind v1.0 in order to take advantage of Tailwind's configuration directive which will allow us to turn off the preflight base styles by adding a configuration option of

corePlugins: {
  container: false,
  preflight: false
}

to address the core issue found in #178

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @samselikoff any concerns with this?

@samselikoff
Copy link
Contributor

Nice work Peter!

I think this still doesn't allow users to disable base styles yet right? That will be another feature?

@psbanka
Copy link
Contributor Author

psbanka commented Dec 12, 2019

That's right @samselikoff — I'm working on a follow-up PR right now to make the inclusion of the presets configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants