Visual-Studio-equivalent code formatting

[strout]

This is likely just a configuration issue, but I'm fairly new to Emacs customization, so it's over my head.

I'd like to have my formatting options match Visual Studio's (because that's what my coworkers use). Can we have a c-style included with csharp-mode (even if not used by default) that matches?

Here's an example of one of the differences I'm having particular trouble with.

[josteink]

This is a known issue, which has yet to be resolved.

It's actually in the test-files for indentation, but commented out, because we don't have any proper settings for this yet:

https://github.com/josteink/csharp-mode/blob/master/test-files/indentation-tests.cs#L56-L61

[cg505]

The culprit for the code that's failing to indent properly in the test file seems to be https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L485, which fails to recognize the presence of a vsemi when the object being initialized is a generic. This is a complicated issue to resolve because we would have to somehow recursively match the generic type parameter, which could itself be a generic.

[josteink]

Wow. Thanks for the lead!

We have some regexp's already to identify a generic clause which should be reusable, but you may be right in that they don't properly identify nested/recursive generic types. (We should probably add some test-cases for that too.)

To implement a truly recursive parser can't really be done with regexp's like we do now (at least not as far as I know, and certainly not without causing catastrophic backtracking?), so I don't think we'll aim for that.

However, being able to not crash upon fairly normal constructs like Func<List<T>,T> or whatever should be considered a reasonable requirement.

Based on your info I'll see what I can find out, but if you feel like issuing a PR, I'm not against that either. If so, here's the list we already got... If not, consider this a note to self :)

• https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L1460
• https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L1465
• https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L1772-L1777

Cheers.

[josteink]

Looking over it again, there's actually two different issues here:

• correct indentation for declaration and assignment of generic types using object initializers. (as mentioned by @cg505 )
• correct indentation for object initializers in function calls (as reported by @strout )

First one is definitely a bug, considering how we indent all other object initializers, and I'll look into that as soon as I have time.

Once the first issue is fixed, and we have consistent indentation for object initializers, we can start looking into the second one. It would be really nice to have too, but I'm not sure where to start to get that one right.

[josteink]

Issue reported by @cg505 should now be fixed, which leaves us the issue of initializers inside function calls.

[theothornhill]

I cannot find the style mentioned by @strout, but I think this should be outside of csharp-mode scope. Lsp-mode handles lots of code actions for reformatting, and we will try our best here to pick acceptable defaults.

Closing this one, but feel free to open if anyone disagrees.

[josteink]

I think this issue is about having indentation style which matches the one you get when you write C# code in Visual Studio or VSCode.

I don't think that necessarily a lsp-mode issue to be honest.

Also: My bad for using a link to master up there, instead of a link to a fixed commit. That makes the line pretty useless now.

[josteink]

Update: Did some history-digging. This is a precise link to what was considered not working:

https://github.com/josteink/csharp-mode/blob/b061f8aedb28ad7c05251244640763612ba7dae7/test-files/indentation-tests.cs#L56-L61

[josteink]

Which... Indents correctly now. So yeah, we can keep this issue closed then 😆