C# style overrides configuration

[Zastai]

csharp-mode explicitly sets the CC mode style to C#, without passing the DONT-OVERRIDE parameter of c-set-style.
As a result, its settings are applied even when specific values have been customized. This is especially problematic because it includes a setting for c-basic-offset, meaning that csharp-mode does not honour a customized indent size.

Whether defaulting the style should be done at all is debatable (that's normally the domain of a mode hook); but if it's done, it should probably be passing a value other than nil or t so that customization is honoured.

[josteink]

Whether defaulting the style should be done at all is debatable

C# has a particular style, and most people expect editors with C#-support to honour the style standardized via Visual Studio. The default is there to keep those people happy. In fact bugs has formerly been filed over the default not being Visual Studio-like.

This is IMO completely unproblematic, as long as those who want something different can customize it to whatever they prefer.

As a result, its settings are applied even when specific values have been customized

And that I agree does sound like a bug.

And from the sound of it, it sounds like you know a pretty simple workaround. If you send it as a PR, I'll see what I can get done on my end :)

[Zastai]

Like I said, it's debatable :) And indeed, as long as customization is honoured, making the VS behaviour the default is perfectly sensible.

At work, so can't do the whole fork/commit/PR thing right now. Will try to remember to do so tonight.
On our dev machine I just added 42 (so (c-set-style "C#" 42)) and byte-compiled; that fixed it. Any other value should work too (e.g. (c-set-style "C#" 'do-not-override-customized-values) should be fine too, and is self-documenting to boot).