-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Stockio to assets placeholder resources #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughREADME.md was updated to add a single new resource entry: Stockio (free stock photos, vectors, and icons) under Learn > General Game Development; no other changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
| - :free: [3D Game Shaders For Beginners](https://github.com/lettier/3d-game-shaders-for-beginners) | ||
| - :free: [Interactive 3D Graphics](https://www.udacity.com/course/interactive-3d-graphics--cs291) | ||
| - :moneybag: [Interactive Computer Graphics](https://www.coursera.org/learn/interactive-computer-graphics) | ||
| - 🖼️ Stockio — Free stock photos, vectors and icons for commercial use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Section placement appears incorrect; verify resource categorization.
The AI summary indicates this entry should be in "Learn > General Game Development," but the code shows it's been added to "Learn > Computer Graphics" at line 555. Additionally, comparing this entry to others in the Computer Graphics section (lines 550–554), all existing entries are structured learning resources (courses, tutorials). Stockio—a stock photo/vector/icon repository—appears to be an asset placeholder resource, not a learning course.
Suggested fix: Move this entry to the "### Assets/Placeholders" section under Graphics (around line 59–83), where similar asset repositories like OpenGameArt, Sketchfab, and Vecteezy already reside. Also add a license legend emoji prefix (:free: if freely available for commercial use, or :money_with_wings: if partially free), consistent with other entries:
-### Computer Graphics
+### Assets/Placeholders
-[other Computer Graphics entries...]
-- 🖼️ Stockio — Free stock photos, vectors and icons for commercial use.
+- :free: 🖼️ [Stockio](https://www.stockio.com) — Free stock photos, vectors and icons for commercial use.Additionally, the PR description did not answer the submission template questions regarding why this link is worth adding or confirm the project's license. Please verify Stockio's licensing terms and confirm the resource aligns with the repository's curation criteria.
I'll verify the claims in the review comment by examining the README.md file structure directly.
🏁 Script executed:
#!/bin/bash
# Extract relevant sections from README.md to verify placement and format claims
echo "=== Lines 50-85 (Assets/Placeholders section) ==="
sed -n '50,85p' README.md
echo ""
echo "=== Lines 530-560 (General Game Development and Computer Graphics sections) ==="
sed -n '530,560p' README.md
echo ""
echo "=== Count occurrences of section headers ==="
grep -n "^### " README.md | head -20Length of output: 4892
Stockio entry is miscategorized and improperly formatted.
This entry belongs in the "#### Assets/Placeholders" section under "## Graphics" (around lines 59-83), not in the "### Computer Graphics" learning section. Stockio is a stock asset repository, consistent with other assets like OpenGameArt and Vecteezy already listed there—not a learning resource like the courses above it.
Additionally, the entry is missing required formatting:
- No license emoji prefix (all entries use
:free:,:moneybag:, or:money_with_wings:) - No URL link in the expected
[Name](url)format
Move this entry to Assets/Placeholders with proper formatting:
- 🖼️ Stockio — Free stock photos, vectors and icons for commercial use.
+ - :free: [Stockio](https://www.stockio.com) — Free stock photos, vectors and icons for commercial use.Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In README.md around line 555, the Stockio entry is miscategorized and improperly
formatted; remove the current line and relocate it into the "####
Assets/Placeholders" subsection under "## Graphics" (around lines 59–83), and
format it to match other asset entries by adding the license emoji prefix and a
markdown link, e.g. use the free emoji (:free:) followed by
[Stockio](https://www.stockio.com) — Free stock photos, vectors and icons for
commercial use., ensuring punctuation and spacing match surrounding entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@issac6666 can you please fix the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Why do you think the link is worth adding on this list?
Please describe the answer here
Does this project has any License?
Please describe the answer here
Summary by CodeRabbit