Delete -emacs-elixir-format files when elixir-format is called uninteractively #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J3RN
changed the title
J3RN
force-pushed
the
delete-emacs-elixir-format-files
branch
from
d9306e8 to
3d977d8
Compare
mjrusso
added a commit
to mjrusso/.emacs.d
that referenced
this pull request
Feb 24, 2023
("Delete -emacs-elixir-format files when elixir-format is called
uninteractively": elixir-editors/emacs-elixir#498)
victorolinasc
approved these changes
Jun 15, 2023
Contributor
victorolinasc
left a comment
victorolinasc
left a comment
There was a problem hiding this comment.
Awesome :) Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
My theory for why these files are left behind when using the hook is the
errorcall inelixir-format--failed-to-format. Per the Emacs documentation:When
elixir-formatis called interactively, theerrorcall inelixir-format--failed-to-formatfunction is not invoked, which explains why the files are not left behind in that case.My fix here was just to wrap the piece that sometimes errors in an
unwind-protectand have(delete-file ...)and(kill-buffer ...)as unwind forms.