Sigil heredoc support #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just realized that triple quotes are valid for all sigils, so a "true fix" might require a different change. iex(1)> ~c""" ...(1)> foo bar ...(1)> """ 'foo bar\n' iex(2)> ~r""" ...(2)> foo bar ...(2)> """ ~r/foo bar\n/ iex(3)> ~W""" ...(3)> foo bar ...(3)> """ ["foo", "bar"] iex(4)> |
Contributor
|
Could you add the full list of supported sigils from: https://github.com/elixir-editors/emacs-elixir/pull/454/files It won't be perfect but I think it would be good enough for now. |
J3RN
force-pushed
the
better-liveview
branch
from
dbfd195 to
bb081e6
Compare
Contributor
Author
|
@axelson Done! 😁 |
jsmestad
reviewed
Dec 16, 2020
| (let ((heredoc-p (save-excursion | ||
| (goto-char (match-beginning 0)) | ||
| (looking-at-p "~[sS]\\(?:'''\\|\"\"\"\\)")))) | ||
| (looking-at-p "~[BCDELNRSTUbcersw]\\(?:'''\\|\"\"\"\\)")))) |
Contributor
There was a problem hiding this comment.
@axelson we should generate tests for these new sigils as it's really easy to break and not notice day-to-day.
Contributor
There was a problem hiding this comment.
Yes, that's a good point and it would be good to include tests for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax highlighting for LiveView with heredocs is broken:
This (single character) change make the
~Lsigil support heredocs:Ideally I would like to apply the interpolation face inside of
<% ... %>, but I'm not really sure how to approach that and this change stands on its own.