Skip to content

Conversation

@dgutov
Copy link
Contributor

@dgutov dgutov commented Nov 27, 2019

As it is now, it freezes on opening any non-trivial file (it's actually just applying font-lock rules very slowly).

It is a bug in elixir-mode, not Emacs. See https://debbugs.gnu.org/38104#20 for full explanation.

Fixes #445.

To avoid backtracking and thus improve font-locking performance.
Necessary in Emacs 27 because of some correctness improvements in 'rx'.

Suggested by Mattias Engdegård in https://debbugs.gnu.org/38104.
They never did anything anyway because 'identifiers' doesn't include
any separators, so the resulting construct could only match one
identifier anyway.
@deadtrickster
Copy link

why it did work prior some recentish emacs 27 commits?

@dgutov
Copy link
Contributor Author

dgutov commented Nov 28, 2019

As explained in the linked discussion, it was an old bug in rx (missing bracketing).

@Trevoke Trevoke merged commit fb1928b into elixir-editors:master Dec 3, 2019
@Trevoke
Copy link
Contributor

Trevoke commented Dec 3, 2019

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map keys regex crashes/zombifies emacs master

3 participants