Skip to content

[WIP] Added two custom hooks and converted AppHeaderMain to FC. #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Added two custom hooks and converted AppHeaderMain to FC. #672

wants to merge 1 commit into from

Conversation

dusanradovanovic
Copy link
Contributor

Description:

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests

Documentation:

  • Requires documentation updates

@dusanradovanovic
Copy link
Contributor Author

This is very much a work in progress but demonstrates how we can simplify our component logic. Please take a look and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aChanEP aChanEP Awaiting requested review from aChanEP

@shaunmaharaj shaunmaharaj Awaiting requested review from shaunmaharaj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusanradovanovic @dr-ep