[WIP] Added max-lines-per-function linting rule to project

[rostyk-kanafotskyy]

Description:

Linting:

• No linting errors

Component Updates:

• Component package requires update on npm @elasticpath/store-components

Tests:

• E2E tests (npm test run with e2e)
• Manual tests

Documentation:

• Requires documentation updates

[aChanEP]

Everything works! Just need to fix up the ep.config.json. And just opened up a discussion about how we want to organize things going forward. I'm good with merging this though! still lots of improvement with seperating concerns, self contained logic and ultimately readability! :D.

EDIT: Might want to look into linting the components directory before merging! for example there are functions in productdisplayitem.main.tsx that far exceed 120 but are not being linted.

[aChanEP]

yes! more functions pls!

[aChanEP]

I think we should use the recommended 50 lines max per function. But omit any functions having to do with rendering. Thoughts? @shaunmaharaj @rostyk-kanafotskyy

Use this exemption here.
// eslint-disable-next-line max-lines-per-function

[shaunmaharaj]

@aChanEP That's a good point, but I believe we have functions with more than 50 lines too and it could be a pain to refactor them all due to the multiple conditions we support.

I'm good with 120 as max lines for now, and we can clean up more once the time comes to integrate Cortex JS

[aChanEP]

works for me! could be wasted work once the CortexJs comes in.

[aChanEP]

Don't think this line is working for components as there are functions in there that are larger than 120 lines

[rostyk-kanafotskyy]

Great catch, fixing it 🙂
Thank you @aChanEP

[aChanEP]

FYI i will be taking over this task!