-
Notifications
You must be signed in to change notification settings - Fork 22
[WIP] Feature/bloomreach search results page WIP - DO NOT MERGE #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aChanEP
wants to merge
87
commits into
master
Choose a base branch
from
feature/bloomreach-search-results-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix banners in production build.
Able to get br search suggestion working
Able to get tabbing and focusing to work correctly
Change the suggestion box to be part of the reference store theme
make suggestion box adhere to styling
Increase the size of the search so that it goes to the very end of header
Extend the size of the suggestion box
get rid of comments
Able to swap focus from keydown
Able to handle using the arrow keys
Place the appropriate guards on the arrow key functions
Fix issue with being unable to arrow down to the suggestions once the suggestions had populated once.
get rid of unecessary if statement
Able to fix issue with the suggestionlistelemeent not being navigable once suggestionlistelement had already been populated
add the ability to press enter on a list item
Change the input type back to search
get rid of unecessary comments
get rid of more comments here
get rid of console.logs and change styling a bit
Able to fix some linter errors but also rename the clashing search bar classes.
Change the way mouse down event is handled
fix linter errors
use es6 default imports and get rid of linter disable line
delete console.log line
Correct typing errors
delete unused functions for now
get rid of uneeded export functions
delete unused variable
Organize the bloomreach folders better in the util folder
Reorganize types
Reorganize all bloomreach service types
Make types less ambigious
Make types more descriptive for bloomreach.searchfacetnavigation
50c1eb7
to
258acd4
Compare
Fix linter errors
Fix all linter issues
delete sensitive br data
Fix bloomreach.appheadersearch.main broken in storybook
place bloomreach search results in storybook
update key entry for each react component
Place facets into storybook
5 tasks
Fix issue with parsing 'OR'
fix linting issues
Fix linter errors
Change naming of configs and the places that use them
* Able to get mlt products showing up in products display page * use async await pattern * Adjust the name of mlt function * get rid of prop types * fix typescript errors * Move state and props into new file * Able to place bloomreach product recommendations into storybook * Add product recommendation configs * add a new line * adjust files to use new configurations properly * Change the naming of the component * change the padding of the title * Fix the linking to product recommendations * revert settings to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements bloomreach search. Once bloomreach is enabled in ep.config.json the search bar presented will do a keyword search on an endpoint described here:
https://help.bloomreach.com/display/BRINT/Product+search+API
.The search results page will be similar in UI to the original search results with two differences:
Bloomreach modules will now each have their own d.ts files outlining their types. No types will be found in the .tsx files. (should refactor all modules to follow this pattern as it is cleaner).
The configurations have been refactored in this PR so the bloomreach autosuggestions component will also need to be re-tested.
Linting:
Component Updates:
Tests:
e2e
)WIP -- Change the bloomreach settings here...
Documentation: