Skip to content

Conversation

aChanEP
Copy link
Contributor

@aChanEP aChanEP commented Sep 24, 2019

Description:

This PR implements bloomreach search. Once bloomreach is enabled in ep.config.json the search bar presented will do a keyword search on an endpoint described here: https://help.bloomreach.com/display/BRINT/Product+search+API.

The search results page will be similar in UI to the original search results with two differences:

  1. The facets are collapsible.
  2. The facets will contain the number of results that a particular facet will filter.

Bloomreach modules will now each have their own d.ts files outlining their types. No types will be found in the .tsx files. (should refactor all modules to follow this pattern as it is cleaner).

The configurations have been refactored in this PR so the bloomreach autosuggestions component will also need to be re-tested.

Linting:

  • No linting errors

Component Updates:

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  1. Paste these BR settings:
    WIP -- Change the bloomreach settings here...
"bloomreach": {
    "env": {
      "baseUri": "http://core.dxpapi.com/api/v1/core/?",
      "accountId": "account_id=6226",
      "authKey": "auth_key=fcao6uq86z58xup0",
      "domainKey": "domain_key=elastic_path",
      "requestId": "request_id=1239723156472",
      "brUID2":"_br_uid_2=uid%3D8030319374785%3Av%3D11.8%3Ats%3D1536857546532%3Ahc%3D111",
      "url": "url=www.bloomique.com",
      "refurl": "ref_url=www.bloomique.com"
    },
    "keywordSearch": {
      "enable": false,
      "requestType": "request_type=search",
      "rows": "rows=10",
      "start": "start=0",
      "facetLimit": "facet.limit=20",
      "fl": "fl=pid%2Ctitle%2Cbrand%2Cprice%2Csale_price%2Cpromotions%2Cthumb_image%2Csku_thumb_images%2Csku_swatch_images%2Csku_color_group%2Curl%2Cprice_range%2Csale_price_range%2Cdescription",
      "searchType": "search_type=keyword"
    },
    "suggestions": {
      "enable": false,
      "baseUri": "http://suggest.dxpapi.com/api/v1/suggest/?",
      "requestType": "request_type=suggest"
    }
  },
  1. Test the keyword search
  2. Test the facet filtering
  3. Start up storybook and notice that rudimentary stories have been placed in

Documentation:

  • Requires documentation updates

Fix banners in production build.
Able to get br search suggestion working
Able to get tabbing and focusing to work correctly
Change the suggestion box to be part of the reference store theme
make suggestion box adhere to styling
Increase the size of the search so that it goes to the very end of header
Extend the size of the suggestion box
get rid of comments
Able to swap focus from keydown
Able to handle using the arrow keys
Place the appropriate guards on the arrow key functions
Fix issue with being unable to arrow down to the suggestions once the suggestions had populated once.
get rid of unecessary if statement
Able to fix issue with the suggestionlistelemeent not being navigable once suggestionlistelement had already been populated
add the ability to press enter on a list item
Change the input type back to search
get rid of unecessary comments
get rid of more comments here
get rid of console.logs and change styling a bit
Able to fix some linter errors but also rename the clashing search bar classes.
Change the way mouse down event is handled
fix linter errors
use es6 default imports and get rid of linter disable line
delete console.log line
Correct typing errors
delete unused functions for now
get rid of uneeded export functions
delete unused variable
Organize the bloomreach folders better in the util folder
Reorganize types
Reorganize all bloomreach service types
Make types less ambigious
Make types more descriptive for bloomreach.searchfacetnavigation
@shaunmaharaj shaunmaharaj changed the title Feature/bloomreach search results page WIP - DO NOT MERGE [WIP] Feature/bloomreach search results page WIP - DO NOT MERGE Sep 25, 2019
Properly uncollapse and collapse facets on reload
add the count to the facet navigation
Add counters to the facets
Add modules to export file
delete unused lines
@aChanEP aChanEP force-pushed the feature/bloomreach-search-results-page branch from 50c1eb7 to 258acd4 Compare September 25, 2019 22:09
Fix linter errors
Fix all linter issues
delete sensitive br data
Fix bloomreach.appheadersearch.main broken in storybook
place bloomreach search results in storybook
update key entry for each react component
Place facets into storybook
@aChanEP aChanEP mentioned this pull request Sep 30, 2019
5 tasks
aChanEP and others added 5 commits October 1, 2019 11:14
Fix issue with parsing 'OR'
fix linting issues
Fix linter errors
Change naming of configs and the places that use them
* Able to get mlt products showing up in products display page

* use async await pattern

* Adjust the name of mlt function

* get rid of prop types

* fix typescript errors

* Move state and props into new file

* Able to place bloomreach product recommendations into storybook

* Add product recommendation configs

* add a new line

* adjust files to use new configurations properly

* Change the naming of the component

* change the padding of the title

* Fix the linking to product recommendations

* revert settings to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant