Skip to content

Adjusted pagination limit to 52. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Adjusted pagination limit to 52. #116

merged 1 commit into from
Apr 15, 2021

Conversation

mwan-ep
Copy link
Contributor

@mwan-ep mwan-ep commented Apr 14, 2021 •
edited
Loading

Description:

Adjusted pagination item limit to 52. It's set to 52 because it is greater than 50 and is divisible by 4. We have 4 products per row.

Linting:

  • No linting errors

Tests:

  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates

@long-wan-ep long-wan-ep merged commit 2f3869e into master Apr 15, 2021
@long-wan-ep long-wan-ep deleted the increase-default-pagination branch April 15, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@long-wan-ep long-wan-ep long-wan-ep approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwan-ep @long-wan-ep