[typedclient] Add responses #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Add typedapi responses * Update integration test with responses & errors * Add highlights for typedapi changes * Add missing license headers * Fix missing pointers * Fix internal test for info on typedclient * Apply linter recommendations
Anaethelion
added a commit
that referenced
this pull request
Mar 10, 2023
* [typedclient] Add responses (#618) * Add typedapi responses * Update integration test with responses & errors * Add highlights for typedapi changes * Add missing license headers * Fix missing pointers * Fix internal test for info on typedclient * Apply linter recommendations * Update specification links for 8.7 branch --------- Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion
added a commit
that referenced
this pull request
Mar 23, 2023
Anaethelion
added a commit
that referenced
this pull request
Mar 23, 2023
Anaethelion
added a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the responses to the
typedclient, each endpoint has its ownResponsetype.It comes with several changes to the API, including the handling of Elasticsearch exceptions as Go errors.
Domethod on endpoints now return a typed response, one per endpoint.Performmethod added on endpoints, returnshttp.Responseas didDo.types.ElasticsearchErrorwith.Asand.Ismethods..Rawnow takes a reader as input._sourceinHitsare nowjson.RawMessageto highlight they later deserializable nature.