Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typed API] Simplification and builder removal #545

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Conversation

Anaethelion
Copy link
Contributor

This PR removes the builder pattern from the types provided within the TypedAPI package.
Following multiple really interesting feedback, the builder pattern proved difficult to use and ill-suited for the creation of complex payloads.

In its place, this update introduces several improvements that will allow to achieve the same result:

  • A simplification of the type schema, removing aliases to only keep union types.
  • Renaming of key types for clarity. (eg: QueryContainer becomes Query, AggregationContainer becomes Aggregations)
  • A package some provided as a helper to allow inline pointers for primitive types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant