Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go bump to 1.17, add docker-compose #414

Merged
merged 7 commits into from
Feb 14, 2022
Merged

go bump to 1.17, add docker-compose #414

merged 7 commits into from
Feb 14, 2022

Conversation

niuguy
Copy link
Contributor

@niuguy niuguy commented Jan 31, 2022

Thanks for the wonderful example on xkcd search. I have made the following two changes to keep it up-to-date and easy for beginners

  1. Bumped go version to 1.17
  2. Added docker-compose which includes elastic server setup

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 31, 2022

💚 CLA has been signed

@Anaethelion Anaethelion self-requested a review February 8, 2022 09:03
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!
I've left only one comment regarding the docker image you used in the docker-compose file.

@Anaethelion
Copy link
Contributor

LGTM

@Anaethelion Anaethelion merged commit f787d7e into elastic:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants