Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents the new deprecations options on the rest-api-spec #41444

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

Mpdreamz
Copy link
Member

Relates #41439 #38613 #35262

cc @elastic/es-clients

@Mpdreamz Mpdreamz added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.2.0 7x labels Apr 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jaymode jaymode removed the 7x label Apr 23, 2019
@Mpdreamz
Copy link
Member Author

run elasticsearch-ci/1

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor things.

@Mpdreamz Mpdreamz merged commit 4430f99 into elastic:master Jun 11, 2019
@Mpdreamz Mpdreamz deleted the fix/document-deprecation-rest-spec branch June 11, 2019 09:38
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Jun 11, 2019
…41444)

* Documents the new deprecations options on the rest-api-spec

Relates elastic#41439 elastic#38613 elastic#35262

* remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Jun 11, 2019
…41444)

* Documents the new deprecations options on the rest-api-spec

Relates elastic#41439 elastic#38613 elastic#35262

* remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit that referenced this pull request Jun 11, 2019
…43090)

* Documents the new deprecations options on the rest-api-spec

Relates #41439 #38613 #35262

* remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit that referenced this pull request Jun 11, 2019
…43089)

* Documents the new deprecations options on the rest-api-spec

Relates #41439 #38613 #35262

* remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants