Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent :: selectors in remote cluster expressions when security is off #125968

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Prevent :: selectors in remote cluster expressions when security is off #125968

merged 1 commit into from
Apr 1, 2025

Conversation

slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Mar 31, 2025 •
edited
Loading

This PR prevents using :: selectors in remote index expressions and adds a basic integration test with security off

Relates to #125252

@slobodanadamovic
Prevent :: selectors in remote cluster expressions when security is off
b04d07d 
This PR prevents using `::` selectors in remote index expressions and adds
a basing integration test with security off

Relates to elastic#125252
@slobodanadamovic slobodanadamovic added >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 31, 2025
@slobodanadamovic slobodanadamovic self-assigned this Mar 31, 2025
@slobodanadamovic slobodanadamovic marked this pull request as ready for review March 31, 2025 19:06
@slobodanadamovic slobodanadamovic requested a review from n1v0lg March 31, 2025 19:07
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

n1v0lg
n1v0lg approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slobodanadamovic slobodanadamovic merged commit 83d7fe0 into elastic:main Apr 1, 2025
22 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125968

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Apr 1, 2025
@slobodanadamovic
Prevent :: selectors in remote cluster expressions when security is o…
9462f52 
…ff (elastic#125968)

This PR prevents using `::` selectors in remote index expressions and adds
a basic integration test with security off.

Relates to elastic#125252

(cherry picked from commit 83d7fe0)

# Conflicts:
#	server/src/main/java/org/elasticsearch/action/ResolvedIndices.java
@slobodanadamovic slobodanadamovic mentioned this pull request Apr 1, 2025
Merged
@slobodanadamovic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Apr 1, 2025
@slobodanadamovic
Prevent :: selectors in remote cluster expressions when security is o…
a54add9 
…ff (#125968) (#126023)

This PR prevents using `::` selectors in remote index expressions and adds
a basic integration test with security off.

Relates to #125252

(cherry picked from commit 83d7fe0)

# Conflicts:
#	server/src/main/java/org/elasticsearch/action/ResolvedIndices.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1v0lg n1v0lg n1v0lg approved these changes

Assignees

@slobodanadamovic slobodanadamovic

Labels
auto-backport Automatically create backport pull requests when merged >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slobodanadamovic @elasticsearchmachine @n1v0lg