Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix ModelRegistryMetadataTests intermittent failures #125883

Merged
merged 6 commits into from
Mar 31, 2025

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Mar 28, 2025

The test is still failing due to wrong expectations when creating a random instance.

Closes #125554

@jimczi jimczi added >test Issues or PRs that are addressing/adding tests :ml Machine learning auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 28, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Mar 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jimczi jimczi merged commit 5582794 into elastic:main Mar 31, 2025
17 checks passed
@jimczi jimczi deleted the model_registry_test_fox branch March 31, 2025 09:44
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125883

@Mikep86
Copy link
Contributor

Mikep86 commented Apr 1, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

Mikep86 pushed a commit to Mikep86/elasticsearch that referenced this pull request Apr 1, 2025
…5883)

unmute test

(cherry picked from commit 5582794)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/registry/ModelRegistryMetadata.java
elasticsearchmachine pushed a commit that referenced this pull request Apr 1, 2025
) (#126042)

* [ML] Fix ModelRegistryMetadataTests intermittent failures (#125883)

unmute test

(cherry picked from commit 5582794)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/registry/ModelRegistryMetadata.java

* Unmute testAlreadyUpgraded

---------

Co-authored-by: Jim Ferenczi <jim.ferenczi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ModelRegistryMetadataTests testUpgrade failing
3 participants