Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sets.newHashSetWithExpectedSize #125327

Merged

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Mar 20, 2025

IJ complains about the static method not being available -- I don't see a reason against using the regular constructor here instead.

@n1v0lg n1v0lg added >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 20, 2025
@n1v0lg n1v0lg self-assigned this Mar 20, 2025
@n1v0lg n1v0lg requested a review from slobodanadamovic March 20, 2025 16:27
@n1v0lg n1v0lg changed the title Use regular HashSet constructor Use Sets. newHashSetWithExpectedSize Mar 20, 2025
Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg n1v0lg marked this pull request as ready for review March 20, 2025 18:25
@n1v0lg n1v0lg requested a review from a team as a code owner March 20, 2025 18:25
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Mar 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 21, 2025
@n1v0lg n1v0lg changed the title Use Sets. newHashSetWithExpectedSize Use Sets.newHashSetWithExpectedSize Mar 21, 2025
@elasticsearchmachine elasticsearchmachine merged commit abd2bdd into elastic:main Mar 21, 2025
22 checks passed
@n1v0lg n1v0lg deleted the use-hash-set-constructor-index-privs branch March 21, 2025 10:04
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125327

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Mar 21, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 21, 2025
IJ complains about the static method not being available -- I don't see
a reason against using the regular constructor here instead.
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
IJ complains about the static method not being available -- I don't see
a reason against using the regular constructor here instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants