Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and unmute entitlements unit tests #125217

Merged
merged 17 commits into from
Mar 24, 2025
Merged

Fix and unmute entitlements unit tests #125217

merged 17 commits into from
Mar 24, 2025

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Mar 19, 2025 •
edited
Loading

Restore tests muted in #124420 and #124006. These were mostly fixed some time ago. (One more fix is applied in this PR.)

Also mutes a couple of tests that broke in the mean time.

@prdoyle prdoyle added >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows auto-backport Automatically create backport pull requests when merged test-entitlements Trigger CI checks using security manager replacement v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 19, 2025
@prdoyle prdoyle self-assigned this Mar 19, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 19, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle prdoyle enabled auto-merge (squash) March 19, 2025 13:36
@prdoyle prdoyle requested a review from a team as a code owner March 19, 2025 13:58
@prdoyle prdoyle changed the title Unmute entitlements unit tests Fix and unmute entitlements unit tests Mar 19, 2025
ldematte
ldematte approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle mentioned this pull request Mar 19, 2025
Open
@prdoyle
Copy link
Contributor Author

prdoyle commented Mar 19, 2025

I'm getting hit by this.

@prdoyle prdoyle mentioned this pull request Mar 20, 2025
Open
@prdoyle prdoyle merged commit 474563f into elastic:main Mar 24, 2025
27 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125217

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 24, 2025
@prdoyle
Unmute entitlements unit tests (elastic#125217)
602e813
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@prdoyle
Unmute entitlements unit tests (#125217) (#125525)
aa666e2
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@prdoyle
Unmute entitlements unit tests (#125217) (#125526)
48ab734
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@prdoyle
Unmute entitlements unit tests (#125217) (#125530)
a55471d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

@prdoyle prdoyle

Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-entitlements Trigger CI checks using security manager replacement test-windows Trigger CI checks on Windows v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prdoyle @elasticsearchmachine @ldematte