Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Added optional parameters to QSTR ES|QL function (#121787) #125112

Merged

Conversation

svilen-mihaylov-elastic
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Adds options to QSTR function.

elastic#118619 added named function parameters. This PR uses this mechanism for allowing query string function parameters, so query string parameters can be used in ES|QL.

Closes elastic#120933

(cherry picked from commit ee4bcac)

# Conflicts:
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Copy link
Contributor

Documentation preview:

@svilen-mihaylov-elastic svilen-mihaylov-elastic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 18, 2025
@svilen-mihaylov-elastic
Copy link
Contributor Author

@elasticsearchmachine test this

elasticsearchmachine and others added 4 commits March 18, 2025 13:09
@svilen-mihaylov-elastic
Copy link
Contributor Author

@elasticsearchmachine test this

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This reverts commit a1d9f56.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@elasticsearchmachine elasticsearchmachine merged commit 3e9bc9b into elastic:8.x Mar 18, 2025
15 checks passed
@svilen-mihaylov-elastic svilen-mihaylov-elastic deleted the backport/8.x/pr-121787 branch March 18, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants