Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare transport version backport to 9.0 for RE_REMOVE_MIN_COMPATIBLE_SHARD_NODE #125095

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Mar 18, 2025

prepare transport version backport to 9.0 for RE_REMOVE_MIN_COMPATIBLE_SHARD_NODE (see #123859)

@mosche mosche added >non-issue :Core/Infra/Core Core issues without another label labels Mar 18, 2025
@mosche mosche requested a review from ldematte March 18, 2025 13:28
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.1.0 labels Mar 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to invert the logic for patch: this is one of the few spot where the logic of the IF is inverted (they test "before" the TransportVersion, not onOrAfter)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit 5479207 into elastic:main Mar 18, 2025
17 checks passed
@mosche mosche deleted the prepare_tv_backport_for_123859 branch March 18, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants