Use FallbackSyntheticSourceBlockLoader for shape and geo_shape #124927
+952
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
added
>enhancement
auto-backport
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @lkts, I've created a changelog YAML for you. |
martijnvg
approved these changes
Mar 17, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
#122891 is not backported, that's why the backport fails |
|
I am going to backport only test changes from #122891 here since it was not intended to be backported |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
lkts
added a commit
that referenced
this pull request
Mar 19, 2025
…124927) (#125164) * Use FallbackSyntheticSourceBlockLoader for shape and geo_shape (#124927) (cherry picked from commit 033d28e) # Conflicts: # server/src/test/java/org/elasticsearch/index/mapper/blockloader/BooleanFieldBlockLoaderTests.java # server/src/test/java/org/elasticsearch/index/mapper/blockloader/DateFieldBlockLoaderTests.java # server/src/test/java/org/elasticsearch/index/mapper/blockloader/KeywordFieldBlockLoaderTests.java # test/framework/src/main/java/org/elasticsearch/index/mapper/BlockLoaderTestCase.java # test/framework/src/main/java/org/elasticsearch/index/mapper/NumberFieldBlockLoaderTestCase.java * fix merge * fix * fix more * fix more * properly sync BlockLoaderTestCase * iter * iter * [CI] Auto commit changes from spotless * f * f --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic implementation of
FallbackSyntheticSourceBlockLoaderfor all spatial fields and uses them forshapeandgeo_shape. Points are not included to limit the size of the change.This PR also integrates new shape fields into the LogsDB challenge tests as a proof of concept of defining new field types outside of the main data generation code base. It required a rework of some parts of data generation and testing infra.