Fix test in TransportGetAllocationStatsActionTests
#124902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyDahlgren
added
>non-issue
:Distributed Coordination/Allocation
DaveCTurner
reviewed
Mar 14, 2025
| EnumSet.of(Metric.ALLOCATIONS), | ||
| EnumSet.of(Metric.FS), | ||
| EnumSet.noneOf(Metric.class), | ||
| EnumSet.allOf(Metric.class) |
There was a problem hiding this comment.
I agree, no reason not to test several meaningful cases here. Could we also add back a random subset too, only done properly this time:
EnumSet.copyOf(randomSubsetOf(EnumSet.allOf(Metric.class)))
There was a problem hiding this comment.
Looks like copyOf() needs at least one element, so I added:
EnumSet.copyOf(randomSubsetOf(between(1, Metric.values().length), EnumSet.allOf(Metric.class)))
DaveCTurner
added
>test
testReturnsOnlyRequestedStats() was using EnumSet.copyOf(randomSubsetOf(Metric.values().length, Metric.values())) which will always return all of the metrics. The code was expecting Metric.ALLOCATIONS and Metric.FS to sometimes not be in the returned set. This change uses an explicit list of EnumSets to cover the range of scenarios expected in the test code.
JeremyDahlgren
force-pushed
the
jdahlgren-fix-testReturnsOnlyRequestedStats
branch
from
ff901b8 to
f1f6827
Compare
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 18, 2025
testReturnsOnlyRequestedStats() was using EnumSet.copyOf(randomSubsetOf(Metric.values().length, Metric.values())) which will always return all of the metrics. The code was expecting Metric.ALLOCATIONS and Metric.FS to sometimes not be in the returned set. This change uses an explicit list of EnumSets to cover the range of scenarios expected in the test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this while reading/testing code for #124898.
testReturnsOnlyRequestedStats()was usingEnumSet.copyOf(randomSubsetOf(Metric.values().length, Metric.values()))which will always return all of the metrics.The code was expecting
Metric.ALLOCATIONSandMetric.FSto sometimes not be in the returned set.This change uses an explicit list of
EnumSets to cover the range of scenarios expected in the test code.