Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] Restore V8 REST compatibility around highlight force_source parameter (#124873) #124881

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

javanna
Copy link
Member

@javanna javanna commented Mar 14, 2025

Backports the following commits to 9.0:

…elastic#124873)

While that was an approved breaking change, the change should have ensured v8
compatibility, so that under v8 compatibility mode the parameter is still accepted,
but rejected in v9 compatibility mode (default).

This commit ensures compatibility and adds a test for it.
@javanna javanna added :Search Relevance/Highlighting How a query matched a document >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Mar 14, 2025
@elasticsearchmachine elasticsearchmachine merged commit c67b4d4 into elastic:9.0 Mar 14, 2025
16 checks passed
@javanna javanna deleted the backport/9.0/pr-124873 branch March 14, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search Relevance/Highlighting How a query matched a document Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants