Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark index.merge.policy.max_merge_at_once_explicit not to be accepted in v10 #124807

Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Mar 13, 2025

Introduce Property.IndexSettingDeprecatedInV9AndRemovedInV10 property setting to mark index settings that accepted on 9.x indices, but not on 10.0.

Property.IndexSettingDeprecatedInV8AndRemovedInV9 doesn't have any specific checks in AbstractScopedSettings#validateDeprecatedAndRemovedSetting, so didn't add any checks for IndexSettingDeprecatedInV9AndRemovedInV10. It's currently used just as a marker.

See #80574, #90264, #120334
See ES-11224

…ed in v10

Introduce `Property.IndexSettingDeprecatedInV9AndRemovedInV10` property setting to mark
index settings that accepted on 9.x indices, but not on 10.0.

See elastic#80574, elastic#90264
See ES-11224
@arteam arteam added >non-issue :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. :Core/Infra/Settings Settings infrastructure and APIs labels Mar 13, 2025
@arteam arteam marked this pull request as ready for review March 13, 2025 20:17
@arteam arteam requested a review from a team as a code owner March 13, 2025 20:17
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team labels Mar 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit 5a159d6 into elastic:main Mar 14, 2025
17 checks passed
@arteam arteam deleted the mark-max-merge-at-once-explicit-removed-v10 branch March 14, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants