ESQL: Fix EvalBenchmark #124736
Merged
ESQL: Fix EvalBenchmark #124736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the benchmark for `EVAL` which was failing because of a strange logging error. The benchmarks really didn't want to run when we use commons-logging. That's fine - we can use the ES logging facade thing. I also added a test to the benchmarks which should run the self-tests for `EVAL` on `gradle check`.
nik9000
added
>non-issue
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Mar 13, 2025
| @@ -52,8 +51,10 @@ dependencies { | |||
| api "org.openjdk.jmh:jmh-core:$versions.jmh" | |||
| annotationProcessor "org.openjdk.jmh:jmh-generator-annprocess:$versions.jmh" | |||
| // Dependencies of JMH | |||
| runtimeOnly 'net.sf.jopt-simple:jopt-simple:5.0.4' | |||
| runtimeOnly 'net.sf.jopt-simple:jopt-simple:5.0.2' | |||
There was a problem hiding this comment.
Without this the tests don't start. It doesn't seem to hurt jmh. If it's trouble later we can deal with it.
| try { | ||
| for (String operation : EvalBenchmark.class.getField("operation").getAnnotationsByType(Param.class)[0].value()) { | ||
| log.info("self testing {}", operation); |
There was a problem hiding this comment.
I wanted to log something to make sure the tests really do something. I figured keeping it in the real benchmark wouldn't hurt. I did have to do the configureESLogging stuff to make it work though.
| @@ -128,7 +128,7 @@ public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) { | |||
|
|
|||
| public abstract static class AbstractEvaluator implements EvalOperator.ExpressionEvaluator { | |||
|
|
|||
| private static final Log logger = LogFactory.getLog(AbstractEvaluator.class); | |||
| private static final Logger logger = LogManager.getLogger(AbstractEvaluator.class); | |||
idegtiarenko
approved these changes
Mar 14, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
Backport: #124922 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 14, 2025
Fix the benchmark for `EVAL` which was failing because of a strange logging error. The benchmarks really didn't want to run when we use commons-logging. That's fine - we can use the ES logging facade thing. I also added a test to the benchmarks which should run the self-tests for `EVAL` on `gradle check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the benchmark for
EVALwhich was failing because of a strange logging error. The benchmarks really didn't want to run when we use commons-logging. That's fine - we can use the ES logging facade thing. I also added a test to the benchmarks which should run the self-tests forEVALongradle check.