Clarify double-response exception #124706
Merged
+54
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing to readers to report `Channel is already closed` in reaction to a double-response bug, and this may be interpreted as a networking issue. We're not really closing anything here, and it's a definite logic bug to call `sendResponse()` twice, so this commit clarifies the actual problem in the exception message.
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
mhl-b
approved these changes
Mar 13, 2025
| close(); | ||
| // protect against double-response bugs | ||
| if (responseSent.compareAndSet(false, true) == false) { | ||
| final var message = "have already sent a response to this request, cannot send another"; |
There was a problem hiding this comment.
cannot send another
we can but we wont
There was a problem hiding this comment.
there's an implicit "without violating the HTTP spec" here I guess ;)
There was a problem hiding this comment.
HTTP Spec:
First shalt thou create the HTTP Response. Then shalt thou count to one, no more, no less. One shall be the number thou shalt count, and the number of the counting shall be one. Two shalt thou not count, neither count thou three, excepting that thou then proceed to one. Five is right out. Once the number one, being the first number, be reached, then lobbest thou thy HTTP Response towards thy foe, who, being naughty in My sight, shall snuff it.
DaveCTurner
added
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
It is confusing to readers to report `Channel is already closed` in reaction to a double-response bug, and this may be interpreted as a networking issue. We're not really closing anything here, and it's a definite logic bug to call `sendResponse()` twice, so this commit clarifies the actual problem in the exception message. Relates ES-10996
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 13, 2025
It is confusing to readers to report `Channel is already closed` in reaction to a double-response bug, and this may be interpreted as a networking issue. We're not really closing anything here, and it's a definite logic bug to call `sendResponse()` twice, so this commit clarifies the actual problem in the exception message. Relates ES-10996 Backport of elastic#124706 to `8.x`
|
Backport is #124809 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
It is confusing to readers to report `Channel is already closed` in reaction to a double-response bug, and this may be interpreted as a networking issue. We're not really closing anything here, and it's a definite logic bug to call `sendResponse()` twice, so this commit clarifies the actual problem in the exception message. Relates ES-10996 Backport of #124706 to `8.x`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing to readers to report
Channel is already closedinreaction to a double-response bug, and this may be interpreted as a
networking issue. We're not really closing anything here, and it's a
definite logic bug to call
sendResponse()twice, so this commitclarifies the actual problem in the exception message.
Relates ES-10996